Go to definition in local orb, targeting other local orb elements was opening a folder instead of making the Go to definition.
Implementation details
The issue is actually that local orbs don't know which yaml they're coming from, so when asked for definition, they give <empty string> and the editor thus try opening the actual directory.
To fix that, the URI field has been added to local orbs and it is passed when making Go to definition.
How to validate
Tests have been added but you can try this yourself by declaring a local orb with executor(s), command(s) and job(s). Have jobs use the local orb's executors or commands and try making go to definition on those to make sure it point to the right point.
Jira: None
Description
Go to definition in local orb, targeting other local orb elements was opening a folder instead of making the
Go to definition.Implementation details
The issue is actually that local orbs don't know which
yamlthey're coming from, so when asked for definition, they give<empty string>and the editor thus try opening the actual directory. To fix that, theURIfield has been added to local orbs and it is passed when makingGo to definition.How to validate
Tests have been added but you can try this yourself by declaring a local orb with executor(s), command(s) and job(s). Have jobs use the local orb's executors or commands and try making go to definition on those to make sure it point to the right point.