Update Ubuntu Again - Githubissues

CircleCI-Public / circleci-yaml-language-server

The official language server for CircleCI YAML configuration files

Apache License 2.0

20 stars 18 forks source link

Update Ubuntu Again #304

Open ambroselittle opened 3 months ago

ambroselittle commented 3 months ago

Hi, was trying to specify the latest (current) ubuntu image of ubuntu-2404:2024.05.1 and it shows an error in VS Code.

So far as I can see, this was last updated in this release.

Any chance y'all could add some automation to update and publish new tags as they are released? In any case, any idea when this will get added? Is it a regular cadence?

cci-jassad commented 2 months ago

Thanks for calling this out @ambroselittle ! Sorry for the delayed reply. I'm opening a ticket with the team to explore your suggestion around automating the updates.

MikeMcC399 commented 1 month ago

@cci-jassad

It seems that ubuntu-2204:2024.05.1 was added through https://github.com/CircleCI-Public/circleci-yaml-language-server/pull/307 and is waiting for a release. The last one was in May 2024.
Time has moved on and now the newer ubuntu-2204:2024.08.1 is also missing. Please add this (and other related missing images) and trigger a release.

kevin-kortum-trustedshops commented 1 month ago

Got ya covered in #309

Edit: The main issue is that the parser does not show the value as unrecognized but expects the docker key instead of the machine. Maybe there is something else that could be improved. In addition, VS Code will try to validate against https://www.schemastore.org/json/ which might not align with the language server.

MikeMcC399 commented 5 days ago

@kevin-kortum-trustedshops

Got ya covered in #309

It seems like you're getting no reaction from the CircleCI organization to your PR #309. Is there any explanation for this?

kevin-kortum-trustedshops commented 5 days ago

@loderunner wanted to take a look at their ci pipeline as it does not seem to run for my PR. I am basically waiting for a review & approve

cci-jassad commented 4 days ago

@MikeMcC399 @kevin-kortum-trustedshops thanks for the engagement and apologies again for our slow response. We're juggling a lot these days 😓 . I'm going to direct one of our engineers to help get #309 over the line.

kevin-kortum-trustedshops commented 23 hours ago

Thanks. We know there is always something going on that is probably more important but you never know until someone writes it down :)