search

CircleCI-Public / config-preview-sdk

Preview SDK for orb authors
85 stars 29 forks source link

experimental notify configuration doesn't work in 2.1 #91

Closed jfirebaugh closed 5 years ago

jfirebaugh commented 5 years ago

I have a config.yml with:

experimental:
  notify:
    branches:
      only:
        - /release-.*/
        - master

However, as soon as I changed version: 2 to version: 2.1, I started getting notifications for every branch. Is this expected? Is there a replacement for this functionality in 2.1?

ndintenfass commented 5 years ago

Confirmed bug. We will fix soon. We will stop stripping this out in 2.1 and continue to pass it through to the execution system. NOTE that we may "fix" this later, as it's considered legacy functionality, but for now we will stop breaking you and pass it through the new config processing.

ndintenfass commented 5 years ago

(note that internal CircleCI reference is: CIRCLE-14259)

marcomorain commented 5 years ago

I've just confirmed that this is fixed 👌

schmijos commented 5 years ago

Has this been "unfixed" lately?

experimental:
  notify:
    branches:
      only:
        - master
        - develop

I get a lot of Slack notifications like this (I'm fiddling around with the CI configuration):

image