search

CircleCI-Public / continuation-orb

MIT License
12 stars 15 forks source link

[semver:patch] Make continue script work on sh #24

Closed TimoPtr closed 2 years ago

TimoPtr commented 2 years ago

Update the continue script to be able to use it with sh instead of bash only.

Fixing https://github.com/CircleCI-Public/continuation-orb/issues/23

TimoPtr commented 2 years ago

@sulami would it be possible to merge this ?

sulami commented 2 years ago

In general yes, though you'll want to rewrite the commit to include the [semver:patch] bit in the subject as well, otherwise this won't release properly.

TimoPtr commented 2 years ago

@sulami done thanks for the heads up

sulami commented 2 years ago

Sorry this took a while, been quite busy last week. This should now be available as 0.3.1.

TimoPtr commented 2 years ago

No problem thank you for the review and merge

SebastienMichoy commented 2 years ago

Hey @sulami, it seems that the commit title used to merge this PR was incorrect (Merge pull request #24 from TimoPtr/fix/sh_usage), meaning that the CI wasn't able to promote a new version of the orb in production. Any idea how to fix it?

More info are available on the job page.

sulami commented 2 years ago

Sébastien MICHOY @.***> writes:

Hey @sulami, it seems that the commit title used to merge this PR was incorrect (Merge pull request #24 from TimoPtr/fix/sh_usage), meaning that the CI wasn't able to promote a new version of the orb in production. Any idea how to fix it?

More info are available on the job page.

I've noticed that as well, but went and manually released the new version. We need to look at fixing the config for this, but I'm not sure if this is maybe a change in how GitHub or CircleCI handle PR merges.

-- Robin

SebastienMichoy commented 2 years ago

Thanks for the clarifications! I assume that the best solution is to edit the commit title in the GitHub interface at the merge step. Not sure you can handle it another way!