CircleCI-Public / flutter-orb

Easily install Flutter SDK and package dependencies. Also wasily run unit test and lint. Supports Linux and macOS
https://circleci.com/developer/orbs/orb/tadashi0713/flutter-orb
MIT License
2 stars 16 forks source link

Use latest Flutter stable and refactor SDK version parameters #15

Closed joshuadeguzman closed 1 year ago

joshuadeguzman commented 2 years ago

SEMVER Update Type:

Description:

The docs for this orb is a bit outdated and might confused newcomers trying out this orb, for example, the version parameter issues.

I fixed the version requirement and make use of flutter_version wherever the Flutter SDK needs to be set.

Next, changed the usage examples with the updated parameters and missing checkout (causes cache key issues).

Last, I updated the default version to the latest stable Flutter SDK release, including the sample app working on the latest SDK.

Motivation:

Checklist:

joshuadeguzman commented 2 years ago

Hey guys, would you be able to take a look at this? @tadashi0713

JalexChen commented 1 year ago

hey @joshuadeguzman - thank you for putting this PR in. at first glance, this looks alright, but we are holding off on releasing any orb updates at the moment. will revisit this in a bit and let the job run

JalexChen commented 1 year ago

Closing this out as the changes made would need to be added with @joshuadeguzman accepting any PRs. Instead, a lot of the changes here are now in PR #23 so that he still gets contributor credit