✏️ fix: use flutter_version instead of version

CircleCI-Public / flutter-orb

Easily install Flutter SDK and package dependencies. Also wasily run unit test and lint. Supports Linux and macOS

https://circleci.com/developer/orbs/orb/tadashi0713/flutter-orb

MIT License

2 stars 16 forks source link

✏️ fix: use flutter_version instead of version #21

Closed Inventrohyder closed 1 year ago

Inventrohyder commented 1 year ago

The example uses version (❌) for the flutter/install_sdk_and_pub job, however, that is incorrect it should be flutter_version (✅).

The flutter/install_sdk_and_pub job only has the following parameters:

app-dir
cache-version
flutter_version
install-location

JalexChen commented 1 year ago

hi @Inventrohyder - thanks for catching this.

flutter_version parameter in the install_sdk_and_pub command is set to be equal to version which is then called by the install_sdk command. this might need to be refactored and if anything, install_sdk_and_pub might need to be a job instead of command.

edit: orbs are currently on hold. will revisit this to re-run the job

JalexChen commented 1 year ago

Actually. I'm going to close this out since #15 makes this change as well as a couple of outstanding issues