Closed JalexChen closed 1 year ago
@KyleTryon @ryanbourdais
These changes shouldn't all be in one PR.
- That's our recommended approach on the team.
- You're forcing all users of the current major version to update just to get a bug fix (version param).
normally i would agree with the smaller PRs, but some of these updates were intertwined with the flutter version, dependency updates, and updating flutter would require some changes in the sample app
i would say the first three commits + checkout commit could be a patch version
the command name change and version parameter can be a minor change. in my mind they are technically "breaking" changes but not necessarily in how it works, so what you said regarding the major version makes sense. i'd like to bundle these two together to limit incrementing the version
how does that sound?
@felicianotech
I see why you wrapped all of this in one PR, but I do agree with Ricardo, this probably should have been 1 for the version changes, 1 for building off of #15 , and another for the breaking change of changing the name of install_android_gradle
. Besides that I do agree that even though it is "breaking" it probably can be rolled into a minor version instead of major, and otherwise it all looks good to me. Definitely happy to see the backlog being cleared with this.
Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/flutter?version=dev:1fcffd3ba8b7aeb448319c7a6261b092f30eeee0
@ryanbourdais - the version changes were already included in #15, but i updated them to something more recent since there are almost a year of updates
i've updated the PR to only include those changes and will have separate PRs for the breaking changes
Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/flutter?version=dev:767a65ab3a529cc345ea374822b48e6ef591e790
Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/flutter?version=dev:e6dce8719ff56ec3d4814893c18dfecdab03faf9
Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/flutter?version=dev:683c2ae2707f44f91e3eb76175df953626dd9a54
Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/flutter?version=dev:b6d07fa74698c0bf289f5c991c71b48f5d898a89
Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/flutter?version=dev:e6dce8719ff56ec3d4814893c18dfecdab03faf9
Your orb has been published to the CircleCI Orb Registry. You can view your published orb on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/flutter?version=1.2.0
Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/flutter?version=dev:b6d07fa74698c0bf289f5c991c71b48f5d898a89
- checkout
step so users who copy it verbatim are not confusedThis will be a patch release