CircleCI-Public / flutter-orb

Easily install Flutter SDK and package dependencies. Also wasily run unit test and lint. Supports Linux and macOS
https://circleci.com/developer/orbs/orb/tadashi0713/flutter-orb
MIT License
2 stars 16 forks source link

CircleCI flutter orb unexpected argument: version #8

Closed svareniem closed 1 year ago

svareniem commented 2 years ago

Orb version:

1.0.1

What happened:

I've got the error:

Error calling workflow: 'distribute'Error calling job: 'distribute'Error calling command: 'flutter/install_sdk_and_pub'Unexpected argument(s): version

Expected behavior:

It should download and install Flutter version passed as argument version.

Additional Information:

Yaml file:

version: '2.1'
orbs:
  flutter: circleci/flutter@1.0.1
jobs:
  distribute:
    macos:
      xcode: 12.5.1
    steps:
      - checkout
      - flutter/install_sdk_and_pub:
          version: 2.8.1
          app-dir: ./app
      - flutter/install_ios_pod:
          app-dir: ./app
      - flutter/install_ios_gem:
          app-dir: ./app
      - run:
          command: bundle exec fastlane ios distribute
          working_directory: ios
workflows:
  distribute:
    jobs:
      - distribute
svareniem commented 2 years ago

Using flutter_version instead of version fixed the error:

- flutter/install_sdk_and_pub:
          flutter_version: 2.8.1

Please update sample documentation.

brenodt commented 2 years ago

I believe this parameter should also be called version. It's unintuitive as all the other jobs that allow for setting the SDK version use that naming convention, so it makes more sense to install_sdk_and_pub maintain this consistency.