CircleCI-Public / gcp-cli-orb

Install and configure the Google Cloud CLI (gcloud)
https://circleci.com/orbs/registry/orb/circleci/gcp-cli
MIT License
9 stars 32 forks source link

Installing gcloud SDK in project root will cause some linting jobs failed #62

Closed yz89122 closed 1 year ago

yz89122 commented 1 year ago

Issue

Installing gcloud SDK in project root will cause linting jobs failed.

In our case, our tool will scan all file with pattern (like *.js, *.cjs) and run linting rules. But this will cause the linting tool is scanning not only target project's code but also gcloud SDK's code. And gcloud's code is written in different coding style from us, this will cause the linting tool always fail.

Request

Allow user to pass the install location as parameter.

https://github.com/CircleCI-Public/gcp-cli-orb/blob/67e4448e40aaaa5f7690dbf7c48228dd73354c3b/src/scripts/install.sh#L7

Or just install at home directory like version 2.4.1.