CircleCI-Public / gcp-cli-orb

Install and configure the Google Cloud CLI (gcloud)
https://circleci.com/orbs/registry/orb/circleci/gcp-cli
MIT License
9 stars 32 forks source link

gcloud component install waiting for user input #65

Open prakash-fb opened 1 year ago

prakash-fb commented 1 year ago

Orb version

3.0.1

What happened

When installing the gcloud component it expects the user to input.

Expected behavior

orbs should install the component without any issues.

image

Any change updating kubectl in cimg:gcp image? It use 1.25 version.

villesau commented 1 year ago

Same here.

villesau commented 1 year ago

Got worked this around. What components is, it essentially just passes what ever it receives to gcloud command, so following fixes the issue:

      - gcp-cli/setup:
          components: 'gke-gcloud-auth-plugin kubectl --quiet'

I'm having a bit difficult time to understand why this kind of abstraction is even needed. Why not installing and using gcloud directly? The orb seems to just add an extra layer of complexity and extra layer of extra issues.

leozhantw commented 9 months ago

Same here.

I'm curious about why don't we just add the --quiet here? 🤔

e.g.

gcloud --quiet components install "$@"

Is there some reason we can't do it there?