CircleCI-Public / gcp-cloud-run-orb

Deploy to Google Cloud Run using this orb from CircleCI
https://circleci.com/orbs/registry/orb/circleci/gcp-cloud-run
MIT License
2 stars 7 forks source link

deploy args don't get passed to cloud run #5

Open tthebst opened 4 years ago

tthebst commented 4 years ago

Orb Version 1.0.2

Describe the bug ENV variables passed in args don't get added to env variables in cloud run

To Reproduce

version: 2.1
orbs:
    gcp-cloud-run: circleci/gcp-cloud-run@1.0.2
jobs:
    build_and_deploy:
        docker:
            - image: 'cimg/base:stable'
        steps:
            - checkout
            - gcp-cloud-run/init
            - gcp-cloud-run/build:
                tag: 'gcr.io/ml-webpage-264418/personal-webpage'
            - gcp-cloud-run/deploy:
                image: 'gcr.io/ml-webpage-264418/personal-webpage'
                platform: managed
                region: europe-west4
                service-name: personal-webpage-circle
                unauthenticated: true
                args: --update-env-vars=[aws_secret_access_key=${aws_secret_access_key},aws_access_key_id=${aws_access_key_id}]

workflows:
    build_and_deploy_to_managed_workflow:
        jobs:
            - build_and_deploy

Expected behavior

Environment variables show up in cloud run yaml file.

Additional context

${aws_secret_access_key} is circleci environment variable. To reproduce can also passs specific value.

KyleTryon commented 4 years ago

Resolved.

Leaving open until the new version of the orb is published. Blocked by #7

mufasa71 commented 4 years ago

@KyleTryon Will it be fixed soon? Thanks

rhernand3z commented 4 years ago

I would like to set environment variables as well via the /deploy command, any updates when this might be fixed?

mareksuscak commented 4 years ago

@KyleTryon any chance we can bump this up in priority? would love to use the official orb but we really need the args parameter

rhernand3z commented 4 years ago

@mareksuscak -- An alternative I went with was using Github Actions, the port from CircleCI --> Github Actions was fairly easy 🚀

Environment Variables are fully supported and Github now supports manual triggers as well -- https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/

Docs: https://github.com/GoogleCloudPlatform/github-actions/blob/master/example-workflows/cloud-run/README.md

tomsaleeba commented 4 years ago

That commit above didn't even work. Here's my workaround that did work: https://github.com/ternandsparrow/wild-orchid-watch-api-facade/blob/f9b0ad0/.circleci/config.yml#L54-L91.

shukryzablah commented 2 years ago

This is still a problem in the latest published version. A solution is to write a custom command by copy pasting and modifying the body.

amoghmishra-sl commented 2 years ago

Any updates on this?

blundin commented 1 year ago

Any updates?