search

CircleCI-Public / gcp-gcr-orb

Orb for interacting with Google Container Registry from within a CircleCI build job
https://circleci.com/orbs/registry/orb/circleci/gcp-gcr
MIT License
13 stars 30 forks source link

Job failing because default remote docker version will be deprecated #90

Open Rapol opened 1 month ago

Rapol commented 1 month ago

Orb version:

version: 2.1
orbs:
  gcp-gcr: circleci/gcp-gcr@0.16.3

executors:
  gcp-executor:
    docker:
      - image: cimg/base:2024.05
...
workflows:
  merge-workflow:
    jobs:
      - gcp-gcr/build-and-push-image:
          context: data
          executor: gcp-executor
          image:  ...
          registry-url: ...
          setup-remote-docker: true
          use-docker-layer-caching: true

What happened:

CircleCI failing because of

This job was rejected because the image 'Remote Docker version: docker-17.09.0-ce' is unavailable

Fix was to set:

remote-docker-version: docker24

Expected behavior:

Orb should default to an approved remote docker version instead of defaulting to 17.09.0-ce which is being deprecated and part of circleci brownout.

Additional Information:

Changing a default is usually pretty risky (will break people stuff) so Im thinking that changing the default value should be a mayor or minor release. Thoughts?

Rapol commented 1 month ago

Default value: https://github.com/CircleCI-Public/gcp-gcr-orb/blob/a0d81fc37bca851ad9b2faf0eae6a26a7205e11d/src/jobs/build-and-push-image.yml#L103