search

CircleCI-Public / gcp-gke-orb

Interact with Google Kubernetes Engine (GKE) from CircleCI
https://circleci.com/orbs/registry/orb/circleci/gcp-gke
MIT License
7 stars 21 forks source link

feat(rollout-image): update field to be able to set the workload type #67

Closed joaomlopes closed 1 year ago

joaomlopes commented 1 year ago

The main motivation is to be able to set an image to a StatefulSet workload. This way we can use the same configuration between Deployment and StatefulSet by just providing one more field. While this change makes the deployment parameter a bit strange since the name doesn't really match if the workload type isn't Deployment, for the sake of existing users and configurations will be kept. The default value will still be deployment to avoid any necessary changes for those that don't have the need to set a different workload type.

joaomlopes commented 1 year ago

@EricRibeiro tagging you here as looked at my previous PR to see if you can look at this one. Let me know if this is something feasible or if it goes against the ORB.

EricRibeiro commented 1 year ago

Obrigado @joaomlopes! 🙇

There is some work that needs to be done in the orb before I can merge your PR. I'll get to it shortly.

joaomlopes commented 1 year ago

Thank you @EricRibeiro 🙏