CircleCI-Public / github-cli-orb

Bring all of the power and flexibility of the GitHub CLI to your CI/CD pipeline.
https://circleci.com/developer/orbs/orb/circleci/github-cli
MIT License
8 stars 27 forks source link

Extract `install` command [semver:minor] #14

Closed jasonkarns closed 2 years ago

jasonkarns commented 2 years ago

closes #13

jasonkarns commented 2 years ago

I added an explicit assertion in the integration test, but I'm not sure how to trigger the circle workflow. They don't appear to be running on PRs.

gmemstr commented 2 years ago

@jasonkarns Due to how orb tests work, we have to manually trigger them - I'm doing so now :)

KyleTryon commented 2 years ago

@jasonkarns Thank you for the contribution! I had not known of any use-cases at the time of creation that would work under different scopes, thank you for sharing this and resolving the issue. The error reported here should be something operational due to a security concern, attempting to resolve it now.

jasonkarns commented 2 years ago

@KyleTryon i appreciate it! you'll notice that I also opened a feature request against the github cli itself that would (hopefully) allow one to invoke gh auth status with reduced scopes. https://github.com/cli/cli/issues/4827

If you have thoughts on how that hypothetical feature should work (as it relates to CI usage), I would welcome your input on that issue.

motionsuggests commented 2 years ago

@jasonkarns This is great! It will make implementing https://github.com/CircleCI-Public/github-cli-orb/issues/9 much easier.

motionsuggests commented 2 years ago

Any word on this?

KyleTryon commented 2 years ago

Apologies @motionsuggests, many orbs to get to. Taking a look at this now/today

KyleTryon commented 2 years ago

Apologies again. Just got the build error resolved and all of the tests have passed. Thank you @jasonkarns Pushing this now!