CircleCI-Public / github-cli-orb

Bring all of the power and flexibility of the GitHub CLI to your CI/CD pipeline.
https://circleci.com/developer/orbs/orb/circleci/github-cli
MIT License
8 stars 27 forks source link

feat: implement support for versions >= v2.28.0 when using macOS or macOS Silicon #47

Closed EricRibeiro closed 10 months ago

EricRibeiro commented 10 months ago

Changes

This PR includes the following changes:

Adds support for versions greater than or equal to v2.28.0

Since v2.28.0, the GH CLI has used .zip instead of .tar.gz in their macOS releases. Since we hard-coded the latter in the download URL, the orb could not handle versions above v2.28.0.

This is not the case anymore. Now, we check which version the user is requesting and act accordingly. If it is < 2.28, we use .tar.gz; otherwise, we use .zip.

Adds several checks to help with troubleshooting

This change introduces several checks and logging (via set -x) to help troubleshoot or follow the orb's execution flow.

Introduces more test-cases

To properly test the new supported versions and platforms, this PR includes the version as another matrix parameter in the integration tests and adds the macOS Silicon executor in the executor matrix.