CircleCI-Public / helm-orb

A CircleCI Orb to simplify deployments to Kubernetes using Helm.
MIT License
11 stars 26 forks source link

`create_namespace` does not create a new namespace and errors silently #74

Closed afdecastro879 closed 10 months ago

afdecastro879 commented 1 year ago

Orb version

3.0.0

What happened

When setting the option create_namespace in the upgrade_helm_chart command the build errors and never sets the option --create-namespace to create a new namespace:

+ '[' -n backstage ']'
+ '[' '' -eq 1 ']'
/bin/bash: line 14: [: : integer expression expected

I think the error is related to the fact that the environment variable in the command is set to HELM_BOOL_CREATE_NAMESPACE (See here) but when using it the script uses HELM_BOOL_CREATE_NAME_SPACE (Note the _ character between the NAME and SPACE See here).

I think the same happens with the install_helm_chart command here

Expected behaviour

Using the upgrade_helm_chart with the create_namespace option should add the --create-namespace option to the final helm command and should create a namespace if does not exists.

afdecastro879 commented 1 year ago

I have opened a PR for this one, but couldn't test it on CI

vdefeo-caylent commented 9 months ago

When is this version going to be published? Still cannot use this fix. Unknown version 3.0.1 for orb circleci/helm

EricRibeiro commented 9 months ago

Done! I'm really sorry for not getting it out sooner.