[semver:patch] deploy-via-git command is using the wrong bash test for string existence

CircleCI-Public / heroku-orb

Easily install and use the Heroku CLI with CircleCI to build, test, and deploy your applications to Heroku.

https://circleci.com/orbs/registry/orb/circleci/heroku

MIT License

6 stars 20 forks source link

[semver:patch] deploy-via-git command is using the wrong bash test for string existence #16

Closed ryanfb closed 4 years ago

ryanfb commented 4 years ago

The bash -z test returns true if the string is empty. The -n test returns true if the string is NOT empty. In the current form of the deploy-via-git command, it will always fail because it will either try to use an empty branch or an empty tag.