Missing issue should not fail builds

CircleCI-Public / jira-connect-orb

Display the status of CircleCI workflows and deployments in Jira!

https://circleci.com/orbs/registry/orb/circleci/jira

MIT License

25 stars 27 forks source link

Missing issue should not fail builds #15

Closed eddiewebb closed 3 years ago

eddiewebb commented 5 years ago

Orb version

1.0.5

What happened

Users complaining that missing issue in commit/branch will fail the job. https://marketplace.atlassian.com/apps/1215946/circleci-for-jira?hosting=cloud&tab=reviews

Expected behavior

Although users might want a highly disciplined workflow (why work on things without wok items) it is clear many dont.

I suggested we default to a soft pass, and allow parameter to override.

kevnm67 commented 4 years ago

@eddiewebb this seemed to be fixed for a while but, after updating to v1.1.6, a missing issue fails the build.

Quickly looking through the orb I'm confused how my build actually failed. The error logged was

200:https://circleci.com/api/v2/me?circle-token=****************************************
null

Exited with code exit status 1

and I only see exit 1 on line 93, which should have additionally logged Curl failed with code ${RESP}. full response below. (in addition to a 200 response code).

dsayling commented 3 years ago

@kevnm67 we believe this is currently fixed in the latest. If you're having any issues still please let us know.

kevnm67 commented 3 years ago

@dsayling Ill report back if it happens again. Lately everything has been working for our org.