Closed eddiewebb closed 2 years ago
I actaully think we shoul;d go full on and add #33, it shouldnt be too hard, and result would be
Coming back around to this on Monday, since it's a holiday in the US. @KyleTryon Going to need a hand with the failing tests.
Given the lack of activity on this PR, coupled with webhooks entering preview on CircleCI and the increasing complexity of the scripts powering this orb, I'm going to opt to close this PR unless someone else would like to pick it up.
Checklist
DO NOT MERGE BEFORE #31
Motivation, issues
Currently all jobs send a
successful
orfailed
status, which is true of the job, but not the workflow if we know subsequent jobs are about to run.This change will inspect the workflow for downstream jobs.
Multi-job workflows will now send intermediate status instead of pass/fail
in_progress
when additional jobs are yet to completepending
when next jobs contain an approval jobsuccesful
to build status on any deployment (otherwise would be left pending)Final jobs or single-job workflows will behave as before,.
Description
Running Jobs
Approval Jobs
Full logic