search

CircleCI-Public / minitest-ci

Minitest reporter plugin for CircleCI
Other
24 stars 25 forks source link

more url friendly test report filename #13

Closed zeroryu closed 7 years ago

zeroryu commented 7 years ago

Allows for better compatibility with circle ci artifact uploads.

ParentClass::ChildClass::ExampleController will generate parent_class/child_class/example_controller-TEST.xml

nwjsmith commented 7 years ago

Since this is a breaking change, could you make it opt-in? An option on Minitest::CI would suffice.

zzak commented 7 years ago

The logic is a little confusing here, saying use_module_name to default true but still uses the old name.

zzak commented 7 years ago

@zeroryu Great! Could you write a test and then squash your commits?

zzak commented 7 years ago

You may want to take a look at #16, thank you for the inspiration @zeroryu!