search

CircleCI-Public / minitest-ci

Minitest reporter plugin for CircleCI
Other
24 stars 25 forks source link

Use digest sha1 for report filenames #19

Closed capripot closed 7 years ago

capripot commented 7 years ago

The way of building filename can lead to very long filenames. We could use Digest::SHA1.hexdigest to keep these filenames short.

It also makes sure that the filename ends with the right extension as "#{string}.xml"[0, 255] would strip away the extension with a string longer than 251.

zzak commented 7 years ago

@capripot Interesting, do you have an example where you've used this on CircleCI?

I wonder if we shouldn't just make it configurable, as most requests seem to be related to changing the output filename.

capripot commented 7 years ago

Closed in favor of #20