search

CircleCI-Public / minitest-ci

Minitest reporter plugin for CircleCI
Other
24 stars 25 forks source link

Minitest fixes #25

Closed zenspider closed 6 years ago

zenspider commented 6 years ago

This includes a fix for minitest-ci to be able to simply run tests at all, but also includes fixes for upcoming changes to minitest. 5.11.0 is going to have some internals change that you depend on. This addresses that in a way that is compatible with current versions.

zenspider commented 6 years ago

I'm not fond of one of the diffs in the last commit. Happy to make any recommended changes.

lostapathy commented 6 years ago

+1'ing this, now that minitest 5.11.0 is out, this is going to affect more people (which is why I'm here).

mrhead commented 6 years ago

I hate to say it, but: +1. We are affected by this, too and can't update minitest.

nwjsmith commented 6 years ago

@zenspider thanks!

nwjsmith commented 6 years ago

@lostapathy @mrhead 3.4.0 has been released with this fix.

lostapathy commented 6 years ago

Thanks @nwjsmith!

mrhead commented 6 years ago

Thank you @nwjsmith!