search

CircleCI-Public / node-orb

An orb for working with Node.js on CircleCI
https://circleci.com/orbs/registry/orb/circleci/node
MIT License
52 stars 80 forks source link

add configurable resource classes #170

Closed jenny-miggin closed 1 year ago

KyleTryon commented 1 year ago

The issue here @jenny-miggin is not related to your change, it is a bug in an older version of orb-tools. We will update and this PR will need to rebase to pull in the change.

KyleTryon commented 1 year ago

When this is merged shortly, you can run:

git checkout master 
git pull
git checkout add-configurable-resource-classes
git rebase
git push -f

https://github.com/CircleCI-Public/node-orb/pull/171

Peter-Darton-i2 commented 1 year ago

FYI this will fix issue #160

orb-publisher commented 1 year ago

Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/node?version=dev:ec842b5e009c5f6acec2f154ce484f080aa2b356

Peter-Darton-i2 commented 1 year ago

I've just run a build against circleci/node@dev:ceb0383ed3c5b425a7dca94eaed22d26de161717 (which is the most recent publish from the main branch) and it LGTM - my build asked for a medium+ and it got what it asked for.

Is there an ETA for a release?

KyleTryon commented 1 year ago

Hey folks, the release will come soon, we are currently blocked by some temporary security measures in place but will publish ASAP.