Prevent nvm from falling back to building from source

CircleCI-Public / node-orb

An orb for working with Node.js on CircleCI

https://circleci.com/orbs/registry/orb/circleci/node

MIT License

52 stars 80 forks source link

Prevent nvm from falling back to building from source #183

Closed JamesHallowell closed 1 week ago

JamesHallowell commented 1 year ago

We've hit an issue that if the binary download fails, then nvm will fall back to building Node from source. This takes a long time and burns through credits, when it'd be quicker to just fail and try the job again.

nvm does support the -b option for installs so that it will only install from binary, and skip installing from source. It would be nice if this orb either set this option all the time, or provided some way to opt in to setting it.

Thanks!

KyleTryon commented 1 year ago

I'm tempted to set it all the time. I doubt anyone really wants to wait that long, if they did they would be far better off building their own image once.

Does anyone have any concerns? we'd probably have to make it a major change, unfortunately.

olleolleolle commented 1 year ago

👋 Hi! We are in the same situation, and would like not to fall back either! Registering "no concerns"!

olleolleolle commented 1 week ago

👋 Here to say, HOORAY!

marboledacci commented 1 week ago

Version https://circleci.com/developer/orbs/orb/circleci/node?version=6.0.0 has this fixed.