search

CircleCI-Public / node-orb

An orb for working with Node.js on CircleCI
https://circleci.com/orbs/registry/orb/circleci/node
MIT License
52 stars 80 forks source link

fix!: do not fall back to source builds of Node.js #185

Closed dsanders11 closed 1 week ago

dsanders11 commented 1 year ago

Closes #183.

Opening a PR to get the ball rolling on this, been bit a few times now by this.

cc @KyleTryon

dsanders11 commented 1 year ago

Note that this change would break Windows, since nvm-windows does not support the -b option. This orb does not officially support Windows, but for practical purposes it does work for Windows (#32 was closed on this basis), but I think the orb needs to clarify an official stance (IMO it should officially support Windows).

olleolleolle commented 10 months ago

Oh, I'd like this, even if it were an option I had to pass to the node-orb settings.

olleolleolle commented 6 months ago

Oh, just now I wanted this feature, the Node 20 build was just too long for the 10-minute window that I had.

cc @KyleTryon Do you know whether this is something planned or anything?

KyleTryon commented 6 months ago

Oh, just now I wanted this feature, the Node 20 build was just too long for the 10-minute window that I had.

cc @KyleTryon Do you know whether this is something planned or anything?

I am no longer an employee of CircleCI. Sorry, I have no insight into anything planned in this org any longer.

olleolleolle commented 6 months ago

@KyleTryon Thanks for responding, and sorry to notify you about this. May your weekend be excellent.

orb-publisher commented 1 week ago

Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/node?version=dev:9ba92079fdaa31fabfb3309ae4cd63a6975439f0