fix: remove unused node-install-dir parameter

CircleCI-Public / node-orb

An orb for working with Node.js on CircleCI

https://circleci.com/orbs/registry/orb/circleci/node

MIT License

52 stars 80 forks source link

fix: remove unused node-install-dir parameter #186

Closed dsanders11 closed 1 week ago

dsanders11 commented 1 year ago

node-install-dir isn't hooked up to anything, and appears to have never been. It's not documented (beyond automatically as a parameter) or tested. Technically a "breaking change" since it removes a parameter, but since the parameter has always been a no-op, there's no functional break (but anyone using the parameter in a config thinking it did something would get an error on updating).

orb-publisher commented 12 months ago

Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/node?version=dev:a7edd58ce2809d26525b7fec217e297df9dff492

KyleTryon commented 12 months ago

We have to make just one small change and then we can update this and merge