CircleCI-Public / node-orb

An orb for working with Node.js on CircleCI
https://circleci.com/orbs/registry/orb/circleci/node
MIT License
52 stars 80 forks source link

Change `install-packages` `include-branch-in-cache-key` default to `false` #197

Open blimmer opened 12 months ago

blimmer commented 12 months ago

Describe Request:

Today, the cache key for install-packages includes the branch name in the cache key by default: https://github.com/CircleCI-Public/node-orb/blob/ab05d0e3718e32232bdd9c80a8ba6fac1c0bee02/src/commands/install-packages.yml#L48-L52

This causes far more cache misses than necessary, IMO, especially because the lockfile hash is already included in the key.

I propose we change the default from true to false in the next major release. This will significantly improve user experience by reducing runtimes.

ssunday commented 11 months ago

Very much agree!