Feat: adding support for pnpm

CircleCI-Public / node-orb

An orb for working with Node.js on CircleCI

https://circleci.com/orbs/registry/orb/circleci/node

MIT License

52 stars 80 forks source link

Feat: adding support for pnpm #199

Closed ramykl closed 2 weeks ago

ramykl commented 9 months ago

SEMVER Update Type:

[ ] Major
[ ] Minor
[ ] Patch

I would assume it is just a patch or minor as it doesn't change any of defaults or the normal behaviours, just adds an optional extra feature of pnpm as a package manager.

Description:

add support for pnpm as a package manager
fix test-deploy.yml node/test and node/run steps to find the correct lock files for the corresponding pkg-manager by removing the other ones

Motivation:

Closes Issues:

Also shows how someone could do this:

https://github.com/CircleCI-Public/node-orb/issues/194
Checklist:

[x] All new jobs, commands, executors, parameters have descriptions.
[x] Usage Example version numbers have been updated.
[ ] Changelog has been updated.

ramykl commented 9 months ago

Not sure what I need to do to get the circleCI checks to run here or if it requires a review to trigger them. I'm not sure the uninstall steps are correct for pnpm as I just took the yarn steps. I didn't see a test for those. Possibly should just be simplified to assume pnpm was installed via npm install -g pnpm.

It would be great to have a bit more documentation about contributing and how to get all the checks to run.

ramykl commented 8 months ago

@KyleTryon Any help on getting these final tests to run here (btw they pass on my circleCI PR to my master branch)? Or what else I can do to get this PR to be processed?

ramykl commented 8 months ago

Here it is against main on my fork with the checks successful and complete https://github.com/ramykl/node-orb/pull/1

jennifer-shehane commented 7 months ago

@KyleTryon Any chance to get a review on this? This would help with support on the cypress orb as well. https://github.com/cypress-io/circleci-orb/pull/445

KyleTryon commented 7 months ago

Hello all 👋 I just got back from vacation and ran your tests, all looks good! We're going to add this shortly, we just want to try to merge in some fixes before adding this feature. I'll update here shortly. Thanks again!