search

CircleCI-Public / node-orb

An orb for working with Node.js on CircleCI
https://circleci.com/orbs/registry/orb/circleci/node
MIT License
52 stars 80 forks source link

ci: migrate to Orb Tools 12 #203

Closed EricRibeiro closed 8 months ago

EricRibeiro commented 8 months ago

Description

This PR updates the Node Orb to the new major version of Orb Tools.

Changes

The comprehensive list of changes can be found below.

Changes in .circleci/config.yml:

  1. Update the orb-tools version from 11.4 to 12.0.
  2. Move the job requirement list from orb-tools/publish to orb-tools/continue.
  3. Remove the orb-tools/publish job since development versions are no longer necessary.
  4. Add the new orb_name parameter in orb-tools/continue.
  5. Rename the orb-tools/continue job parameters to comply with the new snake case standard.
    • orb_name, pipeline_number and vcs_type.

Changes in .circleci/test-deploy.yml:

  1. Update the orb-tools version from 11.4 to 12.0.
  2. Remove the node: circleci/node@dev:<<pipeline.git.revision>> line, and replace it with node: {}.
  3. Rename the orb-tools/publish job parameters to comply with the new snake case standard.
    • orb_name, vcs_type, pub_type, enable_pr_comment and github_token.
  4. Change the orb-tools/pack filter to trigger only on tagged releases.
  5. Remove tests using $CIRCLE_TOKEN

Changes in other files:

  1. Add a shebang to enable shellcheck checks.