search

CircleCI-Public / orb-tools-orb

Various tools for authoring and publishing CircleCI orbs
https://circleci.com/orbs/registry/orb/circleci/orb-tools
MIT License
51 stars 75 forks source link

v10.0.1 does not process includes in the pack step correctly #104

Closed bisrael closed 3 years ago

bisrael commented 3 years ago

Even though the circleci cli locally will pack this project just fine, the cli included with the orb-tools orb does not.

Please see this example:

https://app.circleci.com/pipelines/bitbucket/roadstruck/orb-honk-base/22/workflows/12bfcfc7-d195-499a-9873-2b531572005f

Src here: https://bitbucket.org/roadstruck/orb-honk-base/branch/slack

dsayling commented 3 years ago

@bisrael there was a bug in a recent release of the cli, the change has been reverted. could you verify this is still an issue?

gmemstr commented 3 years ago

The bug in question was with the string matching when we replace the values - dashes in filenames were not matched correctly :)

gmemstr commented 3 years ago

Considering this fixed.