CircleCI-Public / orb-tools-orb

Various tools for authoring and publishing CircleCI orbs
https://circleci.com/orbs/registry/orb/circleci/orb-tools
MIT License
51 stars 74 forks source link

[semver:patch] use BOT_TOKEN instead of TOKEN #105

Closed Chilipp closed 3 years ago

Chilipp commented 3 years ago

as this is how it is defined in https://github.com/CircleCI-Public/orb-tools-orb/blob/master/src/commands/post-pr-comment.yml

Checklist

Motivation, issues

When enabling the Github comment (see the add-pr-comment parameter in dev-promote-from-commit-subject), the command saves the parameter as the BOT_TOKEN environment variable, the script however uses the TOKEN variable. This makes it impossible to use the add-pr-comment: true setting.

Description

use BOT_TOKEN instead of TOKEN in post-pr-comment.sh

gmemstr commented 3 years ago

Nice catch!