CircleCI-Public / orb-tools-orb

Various tools for authoring and publishing CircleCI orbs
https://circleci.com/orbs/registry/orb/circleci/orb-tools
MIT License
51 stars 74 forks source link

fix: RC008 RC009 fixes #131

Closed KyleTryon closed 2 years ago

KyleTryon commented 2 years ago

Changes

These examples will fail:

Not an object

- run: echo test

Missing name

  - run:
      command: echo test

These examples will pass:

Less than 32 char

  - run:
      name: test
      command: echo test

Resolves

KyleTryon commented 2 years ago

Hmm you're right! Thank you. I wonder why shellcheck isn't catching that, even locally.

KyleTryon commented 2 years ago

I've gone ahead and changed the char count up to 64 as well, I could see 32 was not really enough for even tiny things. 64 should be enough to npm/pip install a few items.

orb-publisher commented 2 years ago

Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:333543e4bf602fd1a70c8d378efb9718d67521ac

orb-publisher commented 2 years ago

Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:dd517ddf240d17a96e083b738100ef159095b6b2

orb-publisher commented 2 years ago

Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:3e07cc950f4247b8ac4f5acdc5f188edb4641e9e