CircleCI-Public / orb-tools-orb

Various tools for authoring and publishing CircleCI orbs
https://circleci.com/orbs/registry/orb/circleci/orb-tools
MIT License
51 stars 74 forks source link

Local Review Doesn't Work #140

Open KyleTryon opened 2 years ago

KyleTryon commented 2 years ago

Orb version:

11+

What happened:

Method 1: circleci local execute --job orb-tools/review

Why this wont work: The review job utilizes the save_test_results step which isnt supported locally and will cause the job to fail

Step failed
====>> Uploading test results
Archiving the following test results
  * /tmp/orb_dev_kit/review/review.xml

Error: Failed uploading test results
Error not supported

Method 2: bats ./src/scripts/review.bats

Why this wont work: The review.bats script is local to the orb-tools orb and will not be present in the local files of another orb without cloning it down first.

Expected behavior:

Ideally, it would be possible to run the circleci local execute job locally, though we would need a way to retrieve and then ideally view the JUNIT output.

Better output can be achieved locally by not exporting to JUNIT, but we would need the user to have bats installed and the review script locally.

Other:

https://github.com/CircleCI-Public/circleci-cli/issues/684