search

CircleCI-Public / orb-tools-orb

Various tools for authoring and publishing CircleCI orbs
https://circleci.com/orbs/registry/orb/circleci/orb-tools
MIT License
51 stars 74 forks source link

Enhance check for source URL validity to skip private orbs #142

Closed adamdmharvey closed 1 year ago

adamdmharvey commented 2 years ago

Out of the box, the review check to ensure the URL for source control needs to be public. This (likely? 95%? 😁 ) won't ever be the case for private orbs.

It would be great if this review could also somehow identify if the orb was private, and if so, pass this check successfully - or at least mark it skipped for testing output?

https://github.com/CircleCI-Public/orb-tools-orb/blob/4a32896404b9dcdd7fc6f5885601936ea4262fa1/src/scripts/review.bats#L73-L85

Otherwise, my company has to manually turn this off on all orbs we build as we only build private orbs at the moment.

KyleTryon commented 1 year ago

Though this came first, for interaction I am going to close this as a duplicate of #158, which is now also collapsed into #179 I will take this as a vote for automatically skipping this step for private orbs. Please feel free to add to the discussion in #179