search

CircleCI-Public / orb-tools-orb

Various tools for authoring and publishing CircleCI orbs
https://circleci.com/orbs/registry/orb/circleci/orb-tools
MIT License
51 stars 74 forks source link

We should be able to publish without packing #168

Closed benoittgt closed 1 year ago

benoittgt commented 1 year ago

When using only lint + publish and a custom "orb-dir" like : orb-dir: ./src

File can never be found. Like other jobs we should let the user interact with the code and checkout it. At the moment having the command with "orb-dir: ./src" produces:

  Error: Could not load config file at ./src/orb.yml: open ./src/orb.yml: no such file or directory
nikitajz commented 1 year ago

+1 for this. There are enough cases when orb is simple enough and doesn't require splitting it into complex structure. A plain orb.yml is enough. What I suggest is that orb-tools/publish when detects orb.yml (instead of @orb.yml) fall back to orb-tools/validate with the corresponding log message.

KyleTryon commented 1 year ago

Hey folks,

Could we see your config? The orb wasn't technically designed for this use-case, but it should still work. Happy to take a look.

If you look here: https://github.com/CircleCI-Public/orb-tools-orb/blob/c14c72a5d7ec98ac0d868b551ebbb64966cb2c03/src/scripts/publish.sh#L24

The publish job is only looking for an orb.yml file within a directory, where it comes from should not be relevant. So I believe this should work, with the proper config.

KyleTryon commented 1 year ago

closing as abandoned