fix(scripts): include name and commit hash when publishing

CircleCI-Public / orb-tools-orb

Various tools for authoring and publishing CircleCI orbs

https://circleci.com/orbs/registry/orb/circleci/orb-tools

MIT License

50 stars 74 forks source link

fix(scripts): include name and commit hash when publishing #205

Closed wyardley closed 1 year ago

wyardley commented 1 year ago

Use ORB_PARAM_ORB_NAME vs ORB_VAL_ORB_NAME
Fix literal expansion of CIRCLE_SHA1

Fixes #204

wyardley commented 1 year ago

Note: haven't fixed the SHA1 bit yet - was seeing if I would get a test version published when I submitted this.

KyleTryon commented 1 year ago

Thank you @wyardley. Actually, you showed me we forgot a crucial step. in fact, everything that says param should say val, according to our internal style guides. I am going to quickly go in and fix actually all of the other names instead.

KyleTryon commented 1 year ago

I believe i see the comment issue as well

wyardley commented 1 year ago

Ok, sounds good! I'll close this then.