CircleCI-Public / orb-tools-orb

Various tools for authoring and publishing CircleCI orbs
https://circleci.com/orbs/registry/orb/circleci/orb-tools
MIT License
50 stars 74 forks source link

feat(scripts): add pretty output to review job #206

Closed wyardley closed 1 year ago

wyardley commented 1 year ago

Use pretty output to stdout / stderr, and then also save the junit report

The test results will still be included in the "tests" tab, but this should make the test output a little easier to follow.

note: I'm happy to add back the additional messages and exit code / pointer to look at the tests, but I think this may work as expected without it?

wyardley commented 1 year ago

basic test / poc locally:

image
wyardley commented 1 year ago

@KyleTryon rebased and fixed the shellcheck warning

KyleTryon commented 1 year ago

I think the github outage is making this difficult to test right now

orb-publisher commented 1 year ago

Your development orb(s) have been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link(s): https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:845949f5a119ea93ec72ee854faa25fc0b981b96 https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:alpha

KyleTryon commented 1 year ago

jk it went through 🎉

wyardley commented 1 year ago
image

tested it on one of our projects that uses this with the published tag, and that works Ok. (also, your other fixes work great there too)

wyardley commented 1 year ago
image

and test results still show up too, despite the filename changing slightly (but not the directory)

orb-publisher commented 1 year ago

Your development orb(s) have been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link(s): https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:1d2ddd8fbcda6e84436dc71d49297dc7f2220ee4 https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:alpha

KyleTryon commented 1 year ago

Thank you @wyardley

KyleTryon commented 1 year ago

Though this was technically a feat, I broke the rules to include it as a patch.

image
orb-publisher commented 1 year ago

Your orb has been published to the CircleCI Orb Registry. You can view your published orb on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=12.0.2