Checkout parameter of publish job is not used.

[eddiewebb]

Orb version:

12.0.3

What happened:

While supporting client and looking at means to inject custom logic I noticed the publish job will optinoally attach workspace and then publish, but unlike review/pack jobs never runs checkout, regardless of parameter (step does not exist)

Expected behavior:

Remove parameter or use it in a conditional checkout step.

Additional Information:

[kelvintaywl]

the checkout (bool) parameter is part of the publish job indeed: https://github.com/CircleCI-Public/orb-tools-orb/blob/7b7c2918f9bcc4663539288eedb0a1fa8ce125dd/src/jobs/publish.yml#L78-L82

however, there is no actual conditional step to checkout based on this parameter (i.e., the parameter is not used)

[KyleTryon]

Thanks folks, ill take a look at this shortly.

[jtatarik]

This issue is still present in 12.0.4. Have to work around it by adding explicit checkout pre-step.