CircleCI-Public / orb-tools-orb

Various tools for authoring and publishing CircleCI orbs
https://circleci.com/orbs/registry/orb/circleci/orb-tools
MIT License
51 stars 74 forks source link

Publishing script requires a `v` in the semantic version #221

Closed jakeatoms closed 1 year ago

jakeatoms commented 1 year ago

Orb version: 12.0.4

What happened:

I'm in the process of upgrading to v12 from v10. The production publish job fails because our git tag omits the v and just uses plain digits like 1.0.0.

image

Expected behavior:

It should publish without the v, unless I'm missing something.

Additional Information:

Looking through the Orb docs, their section on versioning does not mention a v being required. Am I looking in the right place or is there some other doc that explains the need for the v?

jakeatoms commented 1 year ago

Just saw this note further down in their docs:

image

I appears a v would not work, so I think this script needs to be updated to remove the expectation of a v in the tag.

jakeatoms commented 1 year ago

Oddly, I seem to have found contradictory information:

image
jakeatoms commented 1 year ago

I just realized that I can customize that via the tag_pattern parameter!

Thanks for thinking of that!