CircleCI-Public / orb-tools-orb

Various tools for authoring and publishing CircleCI orbs
https://circleci.com/orbs/registry/orb/circleci/orb-tools
MIT License
50 stars 74 forks source link

Improve migration docs - build code #230

Open Peter-Darton-i2 opened 6 months ago

Peter-Darton-i2 commented 6 months ago

Split from #220 (into #220, #229 and #230) as CCI can't accept PRs that update the docs, examples and build code all in the same PR.

This PR updates the build code used for this orb to best take advantage of the v12 build capabilities (as described by the migration docs as of #220, as shown in the example as of #229) so that it doesn't do a "dev-publish" for forked-PRs (as they won't have access to the context this needs) and it only "pack"s if tests worked (no point packing if the build has failed).

This makes the build of this orb consistent with the build process that its documentation recommends.