search

CircleCI-Public / orb-tools-orb

Various tools for authoring and publishing CircleCI orbs
https://circleci.com/orbs/registry/orb/circleci/orb-tools
MIT License
51 stars 76 forks source link

feat: Support CircleCI IP Ranges #241

Closed adamharvey-okta closed 3 weeks ago

adamharvey-okta commented 1 month ago

This PR is intended to add support for the CircleCI IP Ranges feature to the Orb Tools Orb.

https://circleci.com/docs/ip-ranges/

By supporting this flag, it means organizations which limit the source IPs accessing their source code can still utilize this orb and it's need to checkout code, without the orb needing to be duplicated or hacked apart to support this in any way.

I also snuck in a minor typo fix in one of the tests.

adamharvey-okta commented 1 month ago

What I'm not 100% sure about is the parameters pass through from the job, to the executor. I believe I have it right, but not yet able to fully test. Will open for review anyway!

david-montano-circleci commented 1 month ago

Hello @adamharvey-okta . Thank you for your contribution. You mention you haven't tested this yet. I understand the idea of the commits but I think that we will also need to use those parameters in the rest of the yaml files or they will just be there are job parameters and wont be used at all.

We will need to come up with some form of testing I will give some thoughts to see if we can confirm the set of IPs mentioned here is actually being used after this.

david-montano-circleci commented 3 weeks ago

I opened a new PR with the missing changes here.