Orb pack 10 shellcheck - Githubissues

CircleCI-Public / orb-tools-orb

Various tools for authoring and publishing CircleCI orbs

https://circleci.com/orbs/registry/orb/circleci/orb-tools

MIT License

51 stars 74 forks source link

Orb pack 10 shellcheck #93

Closed KyleTryon closed 4 years ago

KyleTryon commented 4 years ago

Shellchecked all scripts. Removed shellcheck job Removed check env vars param command Updated JQ version in orb.

lint and pack jobs now run in parallel for slightly faster testing.

KyleTryon commented 4 years ago

Leaving a thought while it's on my mind. Perhaps shellcheck should actually move to it's own orb entirely. It could be imported by orb-tools but doesn't have to be, they can exist entirely separately. Will check later but I think a shellcheck orb might even exist

KyleTryon commented 4 years ago

Removed shellcheck job

Should be moved to its own orb

Removed check env var params

Should be included in the script of the step that requires the information, not a separate step.

Lint and pack jobs run in parallel.

Faster dev time.