CircleCI-Public / path-filtering-orb

MIT License
24 stars 62 forks source link

Add extra parameters to continuation-config or skip path filtering #27

Closed Rawphs closed 1 year ago

Rawphs commented 3 years ago

My team works in a monorepo and path-filtering works wonders, but I'd like to have the option to force-run all workflows and afaik we can't have conditionals on workflows and I can't send extra parameters to the continue_config though this orb.

My suggestion is to allow us to add extra pipeline parameters to the json this orb creates or - if skipping is possible - pass the skip flag to the continue_config instead.

If there's a solution to this that doesn't involve a new feature, please let me know!

rizowski commented 2 years ago

I think I had a similar issue.

I just added a negating look forward pattern and prefixed a new parameter with skip_. It ended up duplicating all of my pipeline parameters but it was easy enough to add. It would be nice for this to be built in or at least allow us to have 2 different configs for fast job passing.

The main reason I want this feature is because in a monorepo and using path filtering, AFAIK you can't require checks without running all jobs so you can fake out github's checks.

ex)

mapping: |
  my-folder/.* run_folder true
  (?!my-folder/).* skip_run_folder true

Edit: Actually I don't know what I was thinking, If you are ok with the workflows running, you can make the first job of every workflow check whether or not the param is passed and exit early or continue to run depending on the pipeline parameter. That's much simpler.

Fernando-Abreu commented 1 year ago

We won't be implementing this, but it can be achieved through the orb command set-parameters.