search

CircleCI-Public / path-filtering-orb

MIT License
24 stars 62 forks source link

Attaching workspace preventing checkout step #32

Closed kochax closed 1 year ago

kochax commented 2 years ago

Orb version: 0.1.0

What happened:

When you provide the workspace_path parameter, attaching of workspace is a step before checkout, so in my case checkout failed with the message:

"Directory (/home/circleci/project) you are trying to checkout to is not empty and not a git repository"

Persist part is done in the previous step: image

and workspace path is defined with: workspace_path: .circleci

Expected behavior:

https://github.com/CircleCI-Public/path-filtering-orb/blob/main/src/jobs/filter.yml

Attach workspace step should be after checkout step

Additional Information:

I can submit PR for this

kochax commented 2 years ago

33

s0rl0v commented 2 years ago

@sulami Hi Robin How are you? Could you please take a look on this? This is pretty much deal breaker for using this orb...

Fernando-Abreu commented 1 year ago

The fix was merged, so I'm closing this