Re-structured project; Add `install-packages` command; Add `test` job - Githubissues

CircleCI-Public / php-orb

A PHP Orb for CircleCI

https://circleci.com/orbs/registry/orb/circleci/php

MIT License

4 stars 17 forks source link

Re-structured project; Add `install-packages` command; Add `test` job #25

Closed tangrufus closed 4 years ago

tangrufus commented 4 years ago

Checklist

[x] All new jobs, commands, executors, parameters have descriptions
[ ] Examples have been added for any significant new features
[ ] README has been updated, if necessary

Motivation, issues

Make php-orb inline with node-orb

Description

Continue the awesome work on #11 by @viveksoundrapandi
Make default executor tag required, see https://github.com/CircleCI-Public/php-orb/pull/11#discussion_r424443650
Move @orb.yml into src/
Add install-packages command, similar to https://github.com/CircleCI-Public/node-orb/blob/30ef903487c6db9bfe447dcde09589daa38f40c9/src/commands/install-packages.yml
Remove load-cache and save-cache commands in favour of install-packages command
Add test job, similar to https://github.com/CircleCI-Public/node-orb/blob/30ef903487c6db9bfe447dcde09589daa38f40c9/src/jobs/test.yml

close #22 close #23 close #24

Help wanted

Without orb write access and build config like https://github.com/CircleCI-Public/node-orb/blob/30ef903487c6db9bfe447dcde09589daa38f40c9/.circleci/config.yml, not sure how to test this PR.

Only test I ran is $ circleci config pack src/ | circleci orb validate -

Sorry for making a giant PR.

tangrufus commented 4 years ago

Note: if we want to install global packages in the setup step, we need https://github.com/CircleCI-Public/cimg-php/pull/52 as well

gmemstr commented 4 years ago

Merging this into the wip-1.0 branch so we can update the CI/CD scripts and add examples. Good work @TangRufus and @viveksoundrapandi :D