CircleCI-Public / python-orb

Common CircleCI tasks for the Python programming language.
https://circleci.com/developer/orbs/orb/circleci/python
MIT License
13 stars 37 forks source link

Update python orb for pipenv, poetry and pip [semver:major] #40

Closed dsayling closed 4 years ago

dsayling commented 4 years ago

Checklist

Motivation, issues

With poetry and pipenv it seems logical to add them to the orb. The node-orb as an example provides a single install command that allows you to choose the pkg-manager you're using - I did this here as well

Description

Condenses the commands into one 'install-packages' command based on the package manager of the user's choosing, with caching around that. Changes test command to job. In this job the packages are installed based on provided pkg-manager. Adds examples for working with all three package managers.

dsayling commented 4 years ago

Planned changes:

FelicianoTech commented 4 years ago

I removed myself as a requested reviewer since this needs more work and keeps showing up on my list. Feel free to add me back when ready, or you can request a review from the entire team with CircleCI-Public/cpeng.

Which btw, once this orb hits v1.0, we need to add a codeowners file for the team.

gmemstr commented 4 years ago

Recommend bumping this to semver:major for a 1.0 release, and tying in any other small tweaks :) @dsayling