search

CircleCI-Public / python-orb

Common CircleCI tasks for the Python programming language.
https://circleci.com/developer/orbs/orb/circleci/python
MIT License
13 stars 37 forks source link

Fix cache key parameter [semver:minor] #44

Closed dsayling closed 4 years ago

dsayling commented 4 years ago

When the schema validation became more restrictive recently, 'key' as a parameter name is not valid at all. Replace it with 'cache-key'. As the current one doesn't work as is, treating like a patch.

Also, why isn't the template loading?

gmemstr commented 4 years ago

@dsayling How would you feel about bumping this to a semver:minor? Considering we're changing a parameter name, which may have inverse affects on people's building when using 0.3 as an orb version number (since we don't have a 1.0, I wouldn't consider this major ;) ).

dsayling commented 4 years ago

Fine with me. Using the parameter would cause a failure, so I don't think anyone is using it anyway.

dsayling commented 4 years ago

Use 1.0.0 orb for caching