search

CircleCI-Public / ruby-orb

The `circleci/ruby` orb source code.
https://circleci.com/developer/orbs/orb/circleci/ruby
MIT License
26 stars 53 forks source link

Fix `rspec-test`'s `include` glob example #136

Closed r7kamura closed 10 months ago

r7kamura commented 10 months ago

The following changes have been added to rspec-test in 2.1.0.

This has changed the way include glob option is expanded.

For example, the description of the include option shows spec/**/*_spec.rb,spec2/**/*_spec.rb as an example, which will no longer work with the current implementation. Now this glob pattern does not find any test files. The correct value is {spec/**/*_spec.rb,spec2/**/*_spec.rb}, (or maybe spec/**/*_spec.rb spec2/**/*_spec.rb could work too).

IMHO the change in 2.1.0 is a breaking change that is not backward compatible. At least in our project, the tests stopped working as a result of the change to this version. At any rate, I think it is better to fix the example value, so I have submitted this pull request.

orb-publisher commented 10 months ago

Your orb has been published to the CircleCI Orb Registry. You can view your published orb on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/ruby?version=2.1.1