search

CircleCI-Public / shellcheck-orb

An orb for ShellCheck, a static analysis tool for shell scripts (https://shellcheck.net) — check all scripts in your repository on every commit
https://circleci.com/developer/orbs/orb/circleci/shellcheck
MIT License
19 stars 26 forks source link

Add "output" parameter for test output retention #11

Closed RogueScholar closed 5 years ago

RogueScholar commented 5 years ago

When I saw this orb I instantly thought "Yes! I knew digging around in this orb documentation like a drunken mole was going to serve a purpose!" which, to my chagrin, was brought to an untimely end when I reviewed the available parameters and saw no mention of a log file option so I could harvest them as artifacts within the workflow. Hopefully this PR will return me to "chair-dancing drunken mole" status and prove beneficial to other users of this orb as well. :hamster:

Honestly I'm just getting my feet wet with your service so I hope I didn't commit any thoroughly embarrassing gaffes in constructing this addition to the config file, but if I did, just let me know and I'll gladly go back and rectify them. I feel I've benefited greatly from your generosity in opening the platform gratis to FOSS projects and am glad I found even a small way to give something back.

Cheers. :clinking_glasses:

iynere commented 5 years ago

@RogueScholar this looks great, thank you !

while you're at it, though, you might also add a store_artifacts line to the job, as well, so folks don't have to remember to add it themselves:

https://circleci.com/docs/2.0/configuration-reference/#store_artifacts

iynere commented 5 years ago

@RogueScholar thank you ! i may want to fiddle with some cosmetic stuff, but i'll get this merged first