CircleCI-Public / shellcheck-orb

An orb for ShellCheck, a static analysis tool for shell scripts (https://shellcheck.net) — check all scripts in your repository on every commit
https://circleci.com/developer/orbs/orb/circleci/shellcheck
MIT License
19 stars 26 forks source link

`shellcheck` should be able to check all shell script code within `run` blocks #12

Closed iynere closed 4 years ago

iynere commented 5 years ago

the orb is currently less useful than it could be, at least w.r.t orb development, because most shell scripts in an orb repo exist within the orb source code, in run blocks.

with some smart yaml / string parsing, this orb should be able to do something like :

gmemstr commented 4 years ago

Something like https://stackoverflow.com/a/21189044 might come in handy here, but I'm hesitant to recommend it. I think using another common language like Python might need to be a stepping stone here. Otherwise I'm not sure what the best solution is. Looks like this has been done in https://github.com/CircleCI-Public/orb-tools-orb/pull/79, so we could port the work from that to here.

KyleTryon commented 4 years ago

Addressed by Orb pack command by relocating shell scripts outside the yaml file.